ResultsCache Extract Histogram #7167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paurush Garg <paurushg@amazon.com>
PaurushGarg
force-pushed
the
results-cache-extract-histogram
branch
from
d12c42e to
2246222
Compare
afhassan
approved these changes
Dec 18, 2025
| } | ||
| } | ||
| if len(result.Samples) == 0 { | ||
| if stream.Histograms != nil { |
Contributor
There was a problem hiding this comment.
nit: I don't think we need to check for nil here since both Samples and Histograms are not nullable
cortex/pkg/querier/tripperware/query.proto
Lines 49 to 50 in f26509f
yeya24
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds Native Histogram extraction logic in Results Cache.
Which issue(s) this PR fixes:
Currently NH extraction is missing in Extract in Result Cache. This produces incorrect results when cache is hit for queries like raw histogram queries (or with aggregation like sum).
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]